Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom root CAs #185

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

piksel
Copy link
Member

@piksel piksel commented Jul 27, 2021

Custom CA support added to the common webclient (pkg/common/webclient), which is now used by slack, telegram, pushbullet and gotify.

Additionally, the SMTP service got a custom implementation.

Adapting the rest of the services to use webclient should be really easy and can be made separately (although releasing with this only supported by some services would need a lot of documentation updates).

Needs integration testing (and more unit tests) and a Router API.

custom CA support was added to the common webclient, which is now used by slack, telegram, pushbullet and gotify
additionally, the SMTP service got a custom implementation
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Attention: Patch coverage is 67.92453% with 51 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (57b43a3) to head (41c0918).
Report is 93 commits behind head on main.

Files Patch % Lines
pkg/util/util_tls.go 0.00% 21 Missing ⚠️
pkg/common/webclient/client.go 77.14% 4 Missing and 4 partials ⚠️
pkg/services/smtp/smtp.go 46.66% 8 Missing ⚠️
pkg/common/webclient/service.go 82.14% 3 Missing and 2 partials ⚠️
pkg/services/gotify/gotify.go 54.54% 3 Missing and 2 partials ⚠️
pkg/services/gotify/gotify_json.go 0.00% 1 Missing ⚠️
pkg/services/slack/slack.go 91.66% 0 Missing and 1 partial ⚠️
pkg/services/telegram/telegram.go 75.00% 0 Missing and 1 partial ⚠️
pkg/services/telegram/telegram_client.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #185       +/-   ##
===========================================
+ Coverage   64.06%   76.23%   +12.16%     
===========================================
  Files          86       90        +4     
  Lines        2758     2748       -10     
===========================================
+ Hits         1767     2095      +328     
+ Misses        839      470      -369     
- Partials      152      183       +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel added this to the v0.6.0 milestone Aug 10, 2021
@piksel piksel force-pushed the feature/custom-tls-certs branch 2 times, most recently from 0c39f09 to c1312da Compare August 11, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant