Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update style of xterm terminal #8986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: update style of xterm terminal #8986

wants to merge 3 commits into from

Conversation

SoniaSandler
Copy link
Contributor

@SoniaSandler SoniaSandler commented Sep 19, 2024 •
edited
Loading

What does this PR do?

This PR adds padding to all terminal instances

Screenshot / video of UI

before:
Screenshot from 2024-09-19 15-17-49
Screenshot from 2024-09-19 13-48-29

after:
Screenshot from 2024-09-19 17-08-26

Screenshot from 2024-09-19 17-08-13

What issues does this PR fix or reference?

Closes #8079

How to test this PR?

  • Tests are covering the bug fix or the new feature

@SoniaSandler SoniaSandler requested review from benoitf and a team as code owners September 19, 2024 19:28
@SoniaSandler SoniaSandler requested review from dgolovin, jeffmaury and gastoner and removed request for a team September 19, 2024 19:28
benoitf
benoitf reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, it is not possible to include the padding in the terminal component ?

AFAIK we should not have to include css file each time we're including a component

@SoniaSandler
Copy link
Contributor Author

SoniaSandler commented Sep 19, 2024 •
edited
Loading

@benoitf I went through the xterm.d.ts file and couldn't find anything for padding, and while searching in the xterm repo, I only found the option of setting the padding in the CSS file.
However, I think I found a workaround by setting the background of the terminal's div to be the same as the background of the terminal and then setting the padding for the div, so I'll update this PR.

benoitf
benoitf reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note not for this commit: should we remove also import import '@xterm/xterm/css/xterm.css'; from the various place

as it's imported by TerminalWindow

jeffmaury
jeffmaury approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shoudn't we have the same padding left and right ?

gastoner
gastoner approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf left review comments

@jeffmaury jeffmaury jeffmaury approved these changes

@gastoner gastoner gastoner approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add padding to all terminal screens.
4 participants
@SoniaSandler @benoitf @jeffmaury @gastoner