Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Containerfile relative path to build context #8924

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SoniaSandler
Copy link
Contributor

What does this PR do?

This PR fixes the Containerfile's relative path when building an image.

Screenshot / video of UI

What issues does this PR fix or reference?

Closes #8460

How to test this PR?

  • Open build image page
  • Choose containerfile to use for the build
  • Change the build context to something different from the default
  • Check that the image is successfully built
  • Tests are covering the bug fix or the new feature

@SoniaSandler
Copy link
Contributor Author

It looks like there is a built in function in the path module of node (path.relative) to get the relative path, but I was not able to import that module to BuildImageFromContainerFile. IIUC, it is not possible to import node:path on the renderer side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building an image with different context folder selected is broken
1 participant