Skip to content

Commit

Permalink
fix: switch to use PodmanRunOptions in Podman Extesion API
Browse files Browse the repository at this point in the history
Signed-off-by: Denis Golovin <[email protected]>
  • Loading branch information
dgolovin committed Sep 20, 2024
1 parent 271cf3b commit 52090e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
***********************************************************************/

import type { ProviderContainerConnection, RunOptions, RunResult } from '@podman-desktop/api';

export interface PodmanRunOptions extends RunOptions {
connection?: ProviderContainerConnection;
}
Expand Down
8 changes: 2 additions & 6 deletions extensions/podman/packages/extension/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1247,12 +1247,8 @@ export function registerOnboardingRemoveUnsupportedMachinesCommand(): extensionA
});
}

async function exec(
args: string[],
connection?: extensionApi.ProviderContainerConnection,
options?: extensionApi.RunOptions,
): Promise<extensionApi.RunResult> {
return execPodman(args, connection?.connection.vmTypeDisplayName, options);
async function exec(args: string[], options?: PodmanRunOptions): Promise<extensionApi.RunResult> {

Check failure on line 1250 in extensions/podman/packages/extension/src/extension.ts

View workflow job for this annotation

GitHub Actions / typecheck

Cannot find name 'PodmanRunOptions'.
return execPodman(args, options?.connection?.connection.vmTypeDisplayName, options);
}

export async function activate(extensionContext: extensionApi.ExtensionContext): Promise<PodmanExtensionApi> {
Expand Down

0 comments on commit 52090e2

Please sign in to comment.