Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance inspect #1626

Merged
merged 1 commit into from
Aug 18, 2022
Merged

enhance inspect #1626

merged 1 commit into from
Aug 18, 2022

Conversation

ningmingxiao
Copy link
Contributor

Signed-off-by: ningmingxiao [email protected]

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2022

Thanks @ningmingxiao
LGTM
@mtrmac @vrothberg PTAL

vrothberg
vrothberg reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please also add a description to the commit message that explains what the commit is about.

types/types.go Show resolved Hide resolved
manifest/docker_schema2.go Outdated Show resolved Hide resolved
@mtrmac
Copy link
Collaborator

mtrmac commented Aug 1, 2022

Note to reviewers: Compare previous #1608.

@mtrmac mtrmac mentioned this pull request Aug 8, 2022
Open
mtrmac
mtrmac reviewed Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall implementation LGTM.

The documentation of “unknown” values in ImageInspectLayer is blocking; the other stylistic/consistency nits are a weaker preference.

internal/image/docker_schema1_test.go Outdated Show resolved Hide resolved
internal/image/oci_test.go Outdated Show resolved Hide resolved
internal/image/docker_schema1_test.go Outdated Show resolved Hide resolved
types/types.go Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
manifest/docker_schema2.go Outdated Show resolved Hide resolved
@mtrmac mtrmac mentioned this pull request Aug 8, 2022
Open
@ningmingxiao
enhance inspect
a576137 
Signed-off-by: ningmingxiao <[email protected]>
mtrmac
mtrmac approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@mtrmac mtrmac merged commit 720be7d into containers:main Aug 18, 2022
@jchunkins jchunkins mentioned this pull request Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ningmingxiao @rhatdan @mtrmac @vrothberg