Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prefix validation to postProcessRegistries #1369

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 1, 2021

Depends on #1368 .

@vrothberg @mtrmac @ashcrow PTAL

@lsm5 lsm5 changed the title Wildcard cert fixes 3 Move prefix validation to postProcessRegistries Sep 1, 2021
lsm5 and others added 2 commits September 20, 2021 10:38
Previously an unset Location was only allowed for wildcarded Prefixes.
This commit will allow configs with emtpy location or empty prefix, so
long as the other is valid.

Remove wildcard prefix check for empty location in rewriteReference.

Fixes:
1. containers#1191 (comment)
2. containers#1191 (comment)

Co-authored-by: Miloslav Trmač <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Empty location is now allowed with a valid prefix, and we check for
these in postProcessRegistries already.

This check doesn't need to exist.

Fixes: containers#1191 (comment)

Signed-off-by: Lokesh Mandvekar <[email protected]>
@mtrmac
Copy link
Collaborator

mtrmac commented Dec 8, 2022

(Marking as draft to reflect the dependency on #1368 .)

@mtrmac mtrmac marked this pull request as draft December 8, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants