Skip to content

Commit

Permalink
FIXMEs
Browse files Browse the repository at this point in the history
Signed-off-by: Miloslav Trmač <[email protected]>
  • Loading branch information
mtrmac committed Feb 8, 2024
1 parent 80440b8 commit 00df874
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions storage/storage_dest.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ type storageImageDestination struct {

// addedLayerInfo records data about a layer to use in this image.
type addedLayerInfo struct {
digest digest.Digest // Mandatory, the digest of the layer.
digest digest.Digest // Mandatory, the digest of the layer.
// FIXME: Is this necessary?
tocDigest digest.Digest // Optional. If tocDigest != "", the layer was pulled by its TOC.
emptyLayer bool // The layer is an “empty”/“throwaway” one, and may or may not be physically represented in various transport / storage systems. false if the manifest type does not have the concept.
}
Expand Down Expand Up @@ -592,7 +593,7 @@ func (s *storageImageDestination) getLayerID(uncompressedDigest digest.Digest, i
defer s.lock.Unlock()

if d, found := s.indexToTOCDigest[index]; found {
return d.Hex() + "-toc", found
return d.Hex() + "-toc", found // FIXME: If this is the first layer, this is not a valid ID.
}

d, found := s.blobDiffIDs[uncompressedDigest]
Expand Down

0 comments on commit 00df874

Please sign in to comment.