Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update contributing guidelines #763

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Feb 6, 2024

Addresses #748

Description

This pull request:

  • Separates setup instructions for conda-store, conda-store-ui, and jupyterlab extension
  • Fork and clone steps are similar, so they are bundled together
  • Updates docs contribution instructions

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 8534f0a
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66ea11cfc299dd0008a65d5f
😎 Deploy Preview https://deploy-preview-763--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
@pavithraes
Copy link
Member Author

TODO: Incorporate updates from #792

@trallard trallard added the area: documentation 📖 Improvements or additions to documentation label Mar 26, 2024
@pavithraes pavithraes mentioned this pull request Jun 25, 2024
3 tasks
Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
| Resource | Localhost port | username | password |
|----------|----------------|----------|----------|
| conda-store web server | [localhost:8080](http://localhost:8080)| `admin` | `password`|
| [JupyterHub](https://jupyter.org/hub) | [localhost:8000](http://localhost:8000) | any | `test` |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [JupyterHub](https://jupyter.org/hub) | [localhost:8000](http://localhost:8000) | any | `test` |

I don't think we have this anymore

Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Signed-off-by: Pavithra Eswaramoorthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
Status: In Progress 🏗
Development

Successfully merging this pull request may close these issues.

2 participants