Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyscf_dispersion #27616

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

wxj6000
Copy link

@wxj6000 wxj6000 commented Sep 18, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyscf-dispersion/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyscf-dispersion/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyscf-dispersion/meta.yaml) and found it was in an excellent condition.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyscf-dispersion/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyscf-dispersion/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyscf-dispersion/meta.yaml) and found it was in an excellent condition.

@wxj6000
Copy link
Author

wxj6000 commented Sep 19, 2024

@conda-forge/staged-recipes I was trying to skip win platform. It still raise error. Otherwise, it is ready for review.

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@wxj6000
Copy link
Author

wxj6000 commented Sep 19, 2024

@conda-forge/help-python-c I was trying to skip win platform. It still raise error. Otherwise, it is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant