Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extra_models to pass extra information to requests #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds extra_models to pass extra information to requests #85

wants to merge 2 commits into from

Conversation

fradeve
Copy link
Contributor

@fradeve fradeve commented Jul 28, 2014

Please read the proposed docs for this.

@fradeve fradeve changed the title Adds extra_models to pass extra informations to requests Adds extra_models to pass extra information to requests Jul 28, 2014
@johnraz
Copy link
Contributor

johnraz commented Jul 28, 2014

@fradeve : I don't have time to look in details right now, is it related to #38 ?

@fradeve
Copy link
Contributor Author

fradeve commented Jul 28, 2014

It allows the creation of an extra_model that can be added to an extra_action; I think the answer is yes. Sorry for not having referenced it.

@johnraz
Copy link
Contributor

johnraz commented Jul 28, 2014

it's ok, It just rang a bell ;-)
Will try to review it asap, could you make sure its rebased against master ?

@fradeve
Copy link
Contributor Author

fradeve commented Oct 15, 2014

Hi johnraz, I've rebased on latest master to ease any effort to review this :)

# dataType = field['dataType'],
# required = field['required'],
# description = unicode(field['description'])
# ))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants