Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV dropped --strict option in 0.6.0 release #83

Merged
merged 2 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade --upgrade-strategy=eager \
asv virtualenv
asv virtualenv packaging

- name: Create NFS file system
run: |
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
echo "ASV_PYTHON=$ASV_PYTHON" >> "$GITHUB_ENV"

- name: Run benchmarks on newest code
run: asv run --strict --show-stderr --python "$ASV_PYTHON" HEAD^-1
run: asv run --show-stderr --python "$ASV_PYTHON" HEAD^-1

- name: Clean out vfat mount
run: rm -rf /tmp/vfat/*
Expand All @@ -92,7 +92,7 @@ jobs:
run: git checkout --force refs/bm/merge-target

- name: Run benchmarks on previous code
run: asv run --strict --show-stderr --python "$ASV_PYTHON" HEAD^-1
run: asv run --show-stderr --python "$ASV_PYTHON" HEAD^-1

- name: Compare benchmarks on previous & newest code
run: asv compare refs/bm/merge-target refs/bm/pr
Expand Down
6 changes: 4 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ commands =
[testenv:benchmark]
skip_install = True
deps =
asv
asv ~= 0.6.0
# needed for virtualenv to work out with asv
packaging
virtualenv
commands =
asv run --strict {posargs} HEAD^1..HEAD
asv run {posargs} HEAD^1..HEAD

[pytest]
addopts = --cov=fscacher --no-cov-on-fail
Expand Down