Add cleanup to folds #904

adithyaov · 2021-02-03T11:54:58Z

Check regressions
Fix compile errors in tests and benchmarks
Fix formatting (<= 80 lines) (Only a few outliers)
Add cleanup to classifySessionsBy

adithyaov · 2021-02-04T08:00:53Z

Regression report attached
report.txt

adithyaov · 2021-02-04T08:10:08Z

src/Streamly/Internal/Data/Array/Prim/MutTypesInclude.hs

@@ -378,6 +378,13 @@ lpackArraysChunksOf n (Fold step1 initial1 extract1) =
            FL.Partial rr -> extract1 rr
            FL.Done () -> return ()

+    clean (Tuple' Nothing r1) = clean1 r1
+    clean (Tuple' (Just buf) r1) = do


Just clean up directly here. Don't perform unnecessary actions.

adithyaov · 2021-02-04T10:26:46Z

src/Streamly/Internal/Data/Array/Stream/Mut/Foreign.hs

@@ -156,6 +156,13 @@ lpackArraysChunksOf n (Fold step1 initial1 extract1) =
            FL.Partial rr -> extract1 rr
            FL.Done _ -> return ()

+    clean (Tuple' Nothing r1) = clean1 r1
+    clean (Tuple' (Just buf) r1) = do
+        r <- step1 r1 buf


Unnecessary action?

adithyaov · 2021-02-04T10:31:02Z

src/Streamly/Internal/Data/Fold/Types.hs

+-- TODO
+-- 1. Rename mkFold-ish combinators
+-- 1. Add cleanup based smart constructors
+


Need suggestions on naming.

adithyaov · 2021-02-04T10:31:26Z

src/Streamly/Internal/Data/Fold/Types.hs

@@ -434,10 +465,14 @@ toList = mkAccum (\f x -> f . (x :)) id ($ [])
 -- Instances
 ------------------------------------------------------------------------------

+-- XXX The reason I used "Monad m" is because it is used by "cleanup". I could
+-- have used applicative for nocleanup but I don't think it really matters.
+


Remove this line after review.

adithyaov · 2021-02-04T10:33:08Z

src/Streamly/Internal/Data/Parser/ParserD.hs

+-- TODO Parsers will also have a cleanup action. The correct behaviour now is
+-- for the parsers to clean up the Fold resources while extracting. This is
+-- omitted now as parser will have a seperate cleanup later.
+


Remove after review.

We could clean up when extracting.

adithyaov · 2021-02-04T10:35:21Z

src/Streamly/Internal/Data/Stream/IsStream/Nesting.hs

@@ -1751,6 +1751,7 @@ data SessionState t m k a b = SessionState
    , sessionOutputStream :: t (m :: Type -> Type) (k, b) -- ^ Completed sessions
    }

+-- XXX Need to check where to cleanup


This is still incomplete. I Will get back to this or the reviewer can help me out if the info is known.

adithyaov · 2021-02-04T10:36:11Z

src/Streamly/Internal/Data/Stream/SVar.hs

-    extract () = liftIO $ sendStop svar winfo
+    extract () = return ()
+
+    cleanup () = liftIO $ sendStop svar winfo


See the effects

adithyaov · 2021-02-04T10:36:22Z

src/Streamly/Internal/Data/Stream/SVar.hs

+    extract _ = return ()
+
+    cleanup True = liftIO $ sendStop svar winfo
+    cleanup False = return ()


See the effects of this.

adithyaov · 2021-02-04T10:39:30Z

src/Streamly/Internal/Network/Inet/TCP.hs

@@ -352,21 +352,27 @@ writeChunks
    => (Word8, Word8, Word8, Word8)
    -> PortNumber
    -> Fold m (Array Word8) ()
-writeChunks addr port = Fold step initial extract
+writeChunks addr port = Fold step initial extract cleanup


Cleanup internal fold in initial on exception?

adithyaov · 2021-02-11T11:21:30Z

src/Streamly/Internal/Data/Array/Prim/TypesInclude.hs

@@ -615,14 +615,22 @@ lpackArraysChunksOf n (Fold step1 initial1 extract1) =
            FL.Partial rr -> extract1 rr
            FL.Done _ -> return ()

+    clean (Tuple3' Nothing' _ r1) = clean1 r1
+    clean (Tuple3' (Just' buf) boff r1) = do


unnecessary action?

harendra-kumar · 2023-11-19T23:27:11Z

Fixed by #2427

adithyaov commented Feb 4, 2021

View reviewed changes

adithyaov force-pushed the fold-cleanup branch from 65496a0 to b8c2fa9 Compare February 4, 2021 10:12

adithyaov commented Feb 4, 2021

View reviewed changes

adithyaov added 2 commits February 4, 2021 16:10

Add cleanup to folds

78eda63

Try keeping lines within 80 columns

60f88bb

adithyaov force-pushed the fold-cleanup branch from b8c2fa9 to 60f88bb Compare February 4, 2021 10:40

adithyaov marked this pull request as ready for review February 4, 2021 10:41

adithyaov linked an issue Feb 10, 2021 that may be closed by this pull request

Add a done action in the Fold type #543

Closed

adithyaov commented Feb 11, 2021

View reviewed changes

adithyaov added this to the 0.8.2 milestone Aug 27, 2021

harendra-kumar modified the milestones: 0.8.2, 0.9.0 Mar 4, 2022

harendra-kumar marked this pull request as draft June 21, 2023 12:49

harendra-kumar mentioned this pull request Jul 12, 2023

Add finalization support to folds #2427

Merged

harendra-kumar modified the milestones: 0.9.0, 0.10.0 Jul 13, 2023

harendra-kumar closed this Nov 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cleanup to folds #904

Add cleanup to folds #904

adithyaov commented Feb 3, 2021 •

edited

Loading

adithyaov commented Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 4, 2021

adithyaov Feb 11, 2021

harendra-kumar commented Nov 19, 2023

Add cleanup to folds #904

Add cleanup to folds #904

Conversation

adithyaov commented Feb 3, 2021 • edited Loading

adithyaov commented Feb 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harendra-kumar commented Nov 19, 2023

adithyaov commented Feb 3, 2021 •

edited

Loading