-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template haskell helpers to generate Unbox instances #2420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid non-boot dependencies and move this to streamly-core package?
5ab8c2d
to
603dea2
Compare
Check perf of Generic vs Template Haskell |
Template haskell version looks significantly faster. |
("Attempting to get size with no constructors (" ++ | ||
$(lift (pprint headTy)) ++ ")")|] | ||
-- One constructor with no fields is a unit type. Size of a unit type is | ||
-- 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some special handling for unit in generic deriving. May want to look more closely in the generic deriving code to make sure nothing is missed..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests seem to pass
Compare store vs streamly serialization |
fb1ab65
to
9102fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should expose deriveUnbox and deriveUnboxWith via the Internal.Data.Unbox module as well.
Combine Unbox and Serialize exposed modules.
See #2489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the CIs.
No description provided.