Unify Array APIs #2391
Merged
Unify Array APIs #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes:#2334 |
harendra-kumar
requested changes
May 22, 2023
| toStreamD :: MonadIO m => MutArray a -> D.Stream m a | ||
| toStreamD arr@MutArray{..} = | ||
| {-# INLINE_NORMAL read #-} | ||
| read :: MonadIO m => MutArray a -> D.Stream m a |
There was a problem hiding this comment.
There should not be a MonadIO constraint. See the Data.Array API.
There was a problem hiding this comment.
it uses "getIndexUnsafe" which requires a MonadIO constraint.
There was a problem hiding this comment.
This is a mutable array. This needs to have a MonadIO constraint.
rnjtranjan
force-pushed
the
unify_Arrays_API
branch
from
40a0a50
to
f990b47
Compare
rnjtranjan
force-pushed
the
unify_Arrays_API
branch
from
98a3306
to
2180806
Compare
rnjtranjan
force-pushed
the
unify_Arrays_API
branch
from
86720de
to
faad01d
Compare
adithyaov
reviewed
Jul 11, 2023
harendra-kumar
force-pushed
the
unify_Arrays_API
branch
from
960a6b4
to
cef152c
Compare
adithyaov
reviewed
Jul 19, 2023
Comment on lines
+645
to
+651
| {-# INLINE fromStreamN #-} | ||
| fromStreamN :: MonadIO m => Int -> Stream m a -> m (MutArray a) | ||
| fromStreamN n = D.fold (writeN n) | ||
|
|
||
| {-# INLINE fromStream #-} | ||
| fromStream :: MonadIO m => Stream m a -> m (MutArray a) | ||
| fromStream = D.fold write |
There was a problem hiding this comment.
Do we need these? INLINE these definations?
harendra-kumar
force-pushed
the
unify_Arrays_API
branch
from
e52014d
to
ad90f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.