Make fromPtrN monadic

composewell · Oct 6, 2024 · 40cbd64 · 40cbd64
1 parent 43f73e7
commit 40cbd64
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/core/src/Streamly/Internal/Data/Array/Type.hs b/core/src/Streamly/Internal/Data/Array/Type.hs
@@ -943,8 +943,6 @@ fromPureStream x = unsafePerformIO $ fmap unsafeFreeze (MA.fromPureStream x)
 -- fromPureStream = runIdentity . D.fold (unsafeMakePure write)
 -- fromPureStream = fromList . runIdentity . D.toList
 
--- XXX This should be monadic.
-
 -- | @fromPtrN len addr@ copies @len@ bytes from @addr@ into an array. The
 -- memory pointed by @addr@ must be pinned or static.
 --
@@ -953,8 +951,8 @@ fromPureStream x = unsafePerformIO $ fmap unsafeFreeze (MA.fromPureStream x)
 --
 -- Note that this should be evaluated strictly to ensure that we do not hold
 -- the reference to the pointer in a lazy thunk.
-fromPtrN :: Int -> Ptr Word8 -> Array Word8
-fromPtrN n addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromPtrN n addr)
+fromPtrN :: MonadIO m => Int -> Ptr Word8 -> m (Array Word8)
+fromPtrN n addr = fmap unsafeFreeze (MA.fromPtrN n addr)
 
 -- | Copy a null terminated immutable 'Addr#' Word8 sequence into an array.
 --