Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scons: SConscript/SConstruct refactor #29207

Closed
wants to merge 30 commits into from
Closed

scons: SConscript/SConstruct refactor #29207

wants to merge 30 commits into from

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Aug 1, 2023 •
edited
Loading

Test builds:

  • linux x86_64
  • darwin
  • agnos aarch64
  • linux aarch64

Other

  • test multithreaded build

fredyshox
fredyshox commented Aug 2, 2023
View reviewed changes
SConstruct
# *** Target and Architecture

## Target name breakdown (target)
## - agnos-aarch64: linux tici aarch64
Copy link
Contributor Author

@fredyshox fredyshox Aug 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adeebshihadeh what do you think about replacing slightly ambiguous larch64 with agnos-aarch64 for TICI platform target?

@fredyshox fredyshox self-assigned this Aug 26, 2023
This was referenced Aug 26, 2023
Closed
Closed
Closed
@fredyshox
Copy link
Contributor Author

Submodules PRs
rednose: commaai/rednose#34
opendbc: commaai/opendbc#926
cereal: commaai/msgq#524

@fredyshox
Copy link
Contributor Author

@adeebshihadeh I've revived this one, could u take a look?

@haraschax
Copy link
Contributor

There are too many things going on in this PR. There are renames, refactors, comment styling changes. Those should all be separated, especially when touching critical things like the constructs.

@fredyshox
Copy link
Contributor Author

fredyshox commented Sep 13, 2023 •
edited
Loading

I agree. I see couple of things that could be separated:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Dec 9, 2023
@adeebshihadeh adeebshihadeh deleted the sconscript-refactor branch January 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh Awaiting requested review from adeebshihadeh

Assignees

@fredyshox fredyshox

Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredyshox @haraschax