Fix example URL shortener code #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in SYNOPSIS is broken. url() was never being called on the service.
There is still a problem with this example though. It looks like Google no longer allowed unauthenticated requests. I get a "quota exceeded" error when trying to run it.
They allow authentication through either OAuth or using API key. OAuth works fine.
With an API key, I don't see how to append it to the request URL. insert() is a POST method, but they expect you to append the key as a a query string (?key=)
I see there's specific code to handle the key parameter for a GET request, but I don't see any way to pass query parameters for non-GET requests.