Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined logger callback implementation #15

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conversation

temeo
Copy link
Contributor

@temeo temeo commented Nov 7, 2018

Added static wsrep::log::logger_fn() method to allow user to
provide logger callback.

Added static wsrep::log::logger_fn() method to allow user to
provide logger callback.
@temeo temeo requested a review from mkaruza November 7, 2018 19:56
Copy link
Contributor

@mkaruza mkaruza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good, but in general how can we distinguish between logs coming from of database, wsrep-lib or galera? Maybe we can use prefix argument in log constructor to indicate that.

@temeo
Copy link
Contributor Author

temeo commented Nov 8, 2018

This look good, but in general how can we distinguish between logs coming from of database, wsrep-lib or galera? Maybe we can use prefix argument in log constructor to indicate that.

Opened a separate issue to address this: #16

@mkaruza mkaruza merged commit a942811 into master Nov 8, 2018
@mkaruza mkaruza deleted the logger-callback branch November 8, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants