- Initialize member cluster ID only on connection to cluster. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeo
requested changes
Nov 6, 2018
include/wsrep/view.hpp
Outdated
| @@ -111,6 +111,12 @@ namespace wsrep | |||
| return (members_.empty() && own_index_ == -1); | |||
| } | |||
|
|
|||
| void fix_own_index(ssize_t i) | |||
There was a problem hiding this comment.
There should not be need to fix own index in view. If the provider passes a view with invalid own index, the provider should be fixed instead.
| { | ||
| assert(id_.is_undefined()); | ||
| id_ = view.members()[view.own_index()].id(); |
There was a problem hiding this comment.
It would be good to have some input validation for view.own_index(). Assert/throw if it is negative or >= view.members().size().
temeo
approved these changes
Nov 7, 2018
it on disconnect. - Don't rely on own index from the view because the view may come from another member (IST/SST), instead always determine own index from own ID. Refs #13
Dbsim has internal map of server objects for SST simulation. This was mapped using server_id, which is not available anymore when server object is constructed. Changed the dbsim to use server name instead for internal mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another member, instead determine own index from own ID.
Refs #13