Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster member ID of the server should be initialized on connection to cluster #13

Open
ayurchen opened this issue Nov 6, 2018 · 0 comments
Open

Cluster member ID of the server should be initialized on connection to cluster #13

ayurchen opened this issue Nov 6, 2018 · 0 comments
Assignees
@ayurchen
Labels
bug Something isn't working

Comments

@ayurchen
Copy link
Member

ayurchen commented Nov 6, 2018

...and should not be changed on subsequent view changes until disconnect.

One rationale: view changes may be a part of IST - i.e. come from other nodes and not reflect member ID or its index in the view correctly.
@ayurchen ayurchen added the bug Something isn't working label Nov 6, 2018
@ayurchen ayurchen self-assigned this Nov 6, 2018
ayurchen added a commit that referenced this issue Nov 6, 2018
@ayurchen
- Initialize member cluster ID only on connection to cluster.
73f8756 
 - Don't rely on own index from the view because the view may come from
   another member, instead determine own index from own ID.

Refs #13
@ayurchen ayurchen mentioned this issue Nov 6, 2018
Merged
temeo added a commit that referenced this issue Nov 6, 2018
@temeo
#13 Fix dbsim to deal with provider generated server id
8019418 
Dbsim has internal map of server objects for SST simulation.
This was mapped using server_id, which is not available
anymore when server object is constructed. Changed the dbsim to
use server name instead for internal mapping.
ayurchen added a commit that referenced this issue Nov 7, 2018
@ayurchen
- restored immutability of the wsrep::view() class by moving index/ID
e30852c 
   logic closer to where it belongs: protocol-specific part of the code,
   `wsrep_provider_v26.cpp`
 - added view object sanity checks to `on_connect()` method

Refs #13
ayurchen added a commit that referenced this issue Nov 8, 2018
@ayurchen
- Initialize member cluster ID only on connection to cluster and forget
488c259 
   it on disconnect.
 - Don't rely on own index from the view because the view may come from
   another member (IST/SST), instead always determine own index from own ID.

Refs #13
ayurchen pushed a commit that referenced this issue Nov 8, 2018
@temeo @ayurchen
#13 Fix dbsim to deal with provider generated server id
7922355 
Dbsim has internal map of server objects for SST simulation.
This was mapped using server_id, which is not available
anymore when server object is constructed. Changed the dbsim to
use server name instead for internal mapping.
ayurchen added a commit that referenced this issue Nov 8, 2018
@ayurchen
- Initialize member cluster ID only on connection to cluster and forget
ea9971d 
   it on disconnect.
 - Don't rely on own index from the view because the view may come from
   another member (IST/SST), instead always determine own index from own ID.

Refs #13
ayurchen pushed a commit that referenced this issue Nov 8, 2018
@temeo @ayurchen
#13 Fix dbsim to deal with provider generated server id
c7e8bfb 
Dbsim has internal map of server objects for SST simulation.
This was mapped using server_id, which is not available
anymore when server object is constructed. Changed the dbsim to
use server name instead for internal mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayurchen ayurchen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayurchen