Disable txsv intel gpu #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjabird
reviewed
Jun 28, 2024
Rbiessy
reviewed
Jun 28, 2024
pgorlani
reviewed
Jul 1, 2024
hjabird
approved these changes
Jul 3, 2024
Rbiessy
approved these changes
Jul 3, 2024
pgorlani
approved these changes
Jul 3, 2024
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Convert check for intel gpu support from macro to function in portblas_helper
Add try/catch to txsv tests to skip it if the operator is not implemented.
Since the support for txsv is checked before calling the implemantion, exception for Arc and GPU MAx is raised before so it is possible to have a default configuration working on iGPUs. Signed-off-by: nscipione <[email protected]>
throw() was deprecated moving to modern approach with noexcept
Update if-checks to cmake best practice
s-Nick
force-pushed
the
disable_txsv_intel_gpu
branch
from
75960e5
to
7ccd123
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables
txsvoperators specifically for Intel ARC and Intel GPU Max GPUs by adding a runtime check on device type, vendor, and name.The new exception is caught in our test suite, allowing us to flag the test as skipped. In cases where
TUNING_TARGETisINTEL_GPUorDPCPP_SYCL_ARCHmatches specific ARC or GPU Max targets,txsvtests are not added to ctest.