-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor get_name for BLAS Level 3 benchmarks #439
Merged
aacostadiaz
merged 5 commits into
aacosta/benchmark_name_2
from
aacosta/benchmark_name_3
Jul 10, 2023
Merged
Refactor get_name for BLAS Level 3 benchmarks #439
aacostadiaz
merged 5 commits into
aacosta/benchmark_name_2
from
aacosta/benchmark_name_3
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacostadiaz
requested review from
OuadiElfarouki,
s-Nick,
muhammad-tanvir-1211 and
pgorlani
June 7, 2023 14:53
s-Nick
approved these changes
Jun 16, 2023
aacostadiaz
force-pushed
the
aacosta/benchmark_name_2
branch
from
June 19, 2023 14:53
45d2aa2
to
3138117
Compare
aacostadiaz
force-pushed
the
aacosta/benchmark_name_3
branch
from
June 19, 2023 15:09
5d789f6
to
c665185
Compare
aacostadiaz
force-pushed
the
aacosta/benchmark_name_2
branch
from
June 19, 2023 16:09
3138117
to
16acc27
Compare
aacostadiaz
force-pushed
the
aacosta/benchmark_name_3
branch
2 times, most recently
from
June 19, 2023 16:15
0a88961
to
9c782c4
Compare
pgorlani
approved these changes
Jul 7, 2023
aacostadiaz
force-pushed
the
aacosta/benchmark_name_2
branch
from
July 7, 2023 17:15
16acc27
to
dcc7c07
Compare
aacostadiaz
force-pushed
the
aacosta/benchmark_name_3
branch
from
July 7, 2023 17:30
9c782c4
to
65b52ce
Compare
* Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks extension * Add mem_type --------- Co-authored-by: Alejandro Acosta <[email protected]>
aacostadiaz
added a commit
that referenced
this pull request
Jul 10, 2023
* Refactor get_name for benchmarks level 1 * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks level 2 * Add mem_type * Fix conflict * Refactor get_name for BLAS Level 3 benchmarks (#439) * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks level 3 * Add mem_type * Refactor get_name for BLAS extension benchmarks (#440) * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks level 2 * Refactor get_name for benchmarks extension * Add mem_type --------- Co-authored-by: Alejandro Acosta <[email protected]> --------- Co-authored-by: Alejandro Acosta <[email protected]> --------- Co-authored-by: Alejandro Acosta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the get_name function in the BLAS Level 3 benchmarks to a common location, ensuring that different backends can obtain uniform benchmark names.