Add metric for uploads per scheduled tasks #718
+33
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.01%
==========================================
Files 475 475
Lines 38089 38091 +2
==========================================
+ Hits 37374 37383 +9
+ Misses 715 708 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 98.07% 98.09% +0.01%
==========================================
Files 434 434
Lines 36734 36736 +2
==========================================
+ Hits 36027 36036 +9
+ Misses 707 700 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 98.07% 98.09% +0.01%
==========================================
Files 434 434
Lines 36734 36736 +2
==========================================
+ Hits 36027 36036 +9
+ Misses 707 700 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 98.07% 98.09% +0.01%
==========================================
Files 434 434
Lines 36734 36736 +2
==========================================
+ Hits 36027 36036 +9
+ Misses 707 700 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/metric-schedule
branch
2 times, most recently
from
fd7b256
to
a740c40
Compare
The `Upload` task schedules multiple `UploadProcessor` tasks and another `UploadFinisher`. This batching is rather accidental because of locking rather than intentional. It might be good to know how uploads are being grouped into a single processor/finisher chain.
Swatinem
force-pushed
the
swatinem/metric-schedule
branch
from
a740c40
to
d5ee646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Uploadtask schedules multipleUploadProcessortasks and anotherUploadFinisher.This batching is rather accidental because of locking rather than intentional. It might be good to know how uploads are being grouped into a single processor/finisher chain.
Also includes a bunch of cleanups and driveby typing fixes.