Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flaky fail count in the process flakes task #705

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

depends on: #699 and codecov/shared#356

daily test rollups are unique by repo, test, branch and date, the goal
is to have a summary of all instances that ran for a test on a given
day. We're basically frontloading part of the aggregation of the test
instances
when we encounter a failure in the process flakes task we want to
update the DailyTestRollup of the test on which we encountered the
failure
Copy link

This PR includes changes to shared. Please review them here: codecov/shared@42f83ec...5cc5f48

@codecov-staging
Copy link

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1 1 0 0
View the top 1 failed tests by shortest run time
 tasks.tests.unit.test_process_flakes
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@codecov-qa
Copy link

codecov-qa bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 108 lines in your changes missing coverage. Please review.

Project coverage is 25.62%. Comparing base (7ebdf9f) to head (046c0ad).

Files with missing lines Patch % Lines
...sks/tests/unit/test_test_results_processor_task.py 8.33% 55 Missing ⚠️
tasks/tests/unit/test_process_flakes.py 3.22% 30 Missing ⚠️
tasks/test_results_processor.py 9.09% 20 Missing ⚠️
tasks/process_flakes.py 25.00% 3 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #705       +/-   ##
===========================================
- Coverage   98.09%   25.62%   -72.48%     
===========================================
  Files         434      434               
  Lines       36618    36743      +125     
===========================================
- Hits        35922     9416    -26506     
- Misses        696    27327    +26631     
Flag Coverage Δ
integration 25.62% <18.18%> (-72.48%) ⬇️
latest-uploader-overall 25.62% <18.18%> (-72.48%) ⬇️
unit 25.62% <18.18%> (-72.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 34.57% <43.90%> (-61.45%) ⬇️
OutsideTasks 27.63% <100.00%> (-70.48%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 90.14% <100.00%> (-9.33%) ⬇️
tasks/process_flakes.py 29.68% <25.00%> (-70.32%) ⬇️
tasks/test_results_processor.py 22.89% <9.09%> (-76.42%) ⬇️
tasks/tests/unit/test_process_flakes.py 1.95% <3.22%> (-96.74%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 10.18% <8.33%> (-89.82%) ⬇️

... and 398 files with indirect coverage changes

Copy link

codecov bot commented Sep 12, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1 1 0 0
View the top 1 failed tests by shortest run time
 tasks.tests.unit.test_process_flakes
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

codecov-public-qa bot commented Sep 12, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 1 tests with 1 failed, 0 passed and 0 skipped.

View the full list of failed tests

pytest

  • Class name:
    Test name: tasks.tests.unit.test_process_flakes

    No failure message available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant