Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArtQRCode.cs #408

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Update ArtQRCode.cs #408

merged 7 commits into from
Apr 17, 2024

Conversation

Tragen
Copy link
Contributor

@Tragen Tragen commented Jun 29, 2022

Fixed dot size calculation where the size is divided instead of multiplied.

Fixed dot size calculaction
@Shane32
Copy link
Contributor

Shane32 commented Apr 6, 2024

Previously the pixel size factor does not appear to have any effect.

With pixel size factor of 0.7: (default is 0.8)

Before:

test

After:

test

Demo of default size factor of 0.8:

test

It would seem that this PR should be merged, assuming this is the intent of the pixel size factor. However, any user code will now generate with smaller dots than previously, as previously it acted as though pixelSizeFactor was 1, and the default is 0.8. Test hashes will need to be updated.

Perhaps the default should be set to 1.0 going forward, to match the previous version's default behavior (??)

@Shane32
Copy link
Contributor

Shane32 commented Apr 13, 2024

Changed the default to 1.0 to avoid breaking changes due to bugfix in pixelSizeFactor calculation
Copy link
Contributor

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codebude codebude merged commit 295730d into codebude:master Apr 17, 2024
1 check passed
@Tragen Tragen deleted the patch-1 branch May 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants