Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Leveage T3 ENV Type safety #1290

Closed
wants to merge 1 commit into from

Conversation

vanshavenger
Copy link
Contributor

@vanshavenger vanshavenger commented Sep 20, 2024

Moved the Env varibales to the t3-oss/t3-env for better env typesafety.

Few issues i found down the line.

  1. The CMS variable always comes as a string in the process.env so statements like if(process.env.LOCAL_CMS_PROVIDER) won't work properly. In this i have converted the env cariable to Boolean to fix this issue.
  2. Added ENV variables which were missing in the env.sample but was used in the repo

There was not linting and format error as you can see in the attach image the build was successful.

If any changes required, please let me know to fix them on priority

Screenshot 2024-09-21 at 2 20 27 AM

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@devsargam
Copy link
Collaborator

Don't think it's needed here atm. It creates a lot of complexity too. I really love t3 env but closing this. Sorry

@devsargam devsargam closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants