Implement global search with cmdk and UI enhancements
#1270
+1,033
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `cmdk` for shortcuts whiletraversing - Added Command component from `shadcn/ui` - Fixed duplicates in `README.md`
- Replaced Questions icon in `Appbar.tsx` and `ProfileDropdown.tsx` - Added external links for Cohorts 1, 2, 3 & Web3 in `ExternalLinks.tsx` - Updated icon sizes and improved `Logout` button styling
- Integrated `cmdk` for enhanced command palette functionality - Optimized Navbar components using `useCallback` and `useMemo` to prevent unnecessary re-renders - Refined state and event handling within the Navbar
- Enhanced mobile UI with toggleable search bar - Add navigation hotkeys to command dialog - Implemented debounced search & memoization for better performance - Updated `package.json` and `pnpm-lock.yaml`
gupta-soham
force-pushed
the
ui/cmdK-SearchBar
branch
from
7e1d739
to
ae20d79
Compare
|
@devsargam @hkirat @manuarora700 @siinghd |
|
Another pr for global search is already in 3rd iteration so closing this |
|
Context for kirat: This pr is alternate to #1205. It has 1k changes while other has 300lines. Feel free to pick and merge. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Implemented global search functionality:
SearchBarwithin theNavbarcmdkpackage (similar toshadcn/ui)⌘+KorCtrl+KUpdated UI:
Documentation and routing updates:
README.mdcode100xrepoChecklist before requesting a review
.nextbuildPreview: New Search Bar & UI Enhancements (Desktop)
Recording.2024-09-19.160609.2.mp4
Preview: New Search Bar (Mobile)
mobile.mp4