Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed three dots menu on comments shown to all users #1265

Closed
wants to merge 1 commit into from

Conversation

karranx
Copy link

@karranx karranx commented Sep 19, 2024

PR Fixes:

  • 1 Three dots menu on comments shown to all users and not just the owner of the comment

Resolves #1259

Checklist before requesting a review

  • [ yes ] I have performed a self-review of my code
  • [ yes ] I assure there is no similar/duplicate pull request regarding same issue

@MeerUzairWasHere
Copy link
Contributor

lol, 17 files
are you kidding me?

@Dhaneshwarguiyan
Copy link

Dhaneshwarguiyan commented Sep 20, 2024

@MeerUzairWasHere It is happening due to Code Linting and Formatting I have experienced the same ,I had changed only three lines and after running npm run lint:check/fix and same for the format These many files have changed

@Dhaneshwarguiyan
Copy link

Even without running the npm run lint:fix/format:fix, when commiting the changes it happens by default

@Dhaneshwarguiyan
Copy link

and the linting is so irregular ,
is this an issue or it is made like that
Screenshot from 2024-09-20 10-42-40
You can see in the above file the imports go to the same line same line and on different line for some imports

@karranx
Copy link
Author

karranx commented Sep 20, 2024

@MeerUzairWasHere it also fixes linting and makes the code more in-line with the rest of the code base. without this, it will fail the linting check.

@devsargam
Copy link
Collaborator

Closign in favour of #1260

@devsargam devsargam closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Able to click on 3 dots (options) for comments not authored by the user
4 participants