Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where the "Custom" pipeline cannot use post-processing in WebGL 1.0. #17600

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

GengineJS
Copy link
Contributor

@GengineJS GengineJS commented Sep 4, 2024

Greptile Summary

This pull request addresses an issue where the "Custom" pipeline was unable to use post-processing effects in WebGL 1.0 contexts. The changes focus on optimizing the rendering pipeline, particularly in the management and updating of descriptor buffers.

Key changes include:

  • Refactored descriptor buffer management for more efficient updates
  • Introduced granular control over constant buffer updates with new functions
  • Modified the updatePerPassUBO function to use optimized update methods
  • Improved handling of lights and shadows for better performance in WebGL 1.0
  • Optimized creation and management of descriptor buffers to reduce unnecessary updates

These optimizations should enable post-processing effects to work properly with the "Custom" pipeline in WebGL 1.0, while also potentially improving overall rendering performance.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Sep 4, 2024

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e merged commit ef76162 into cocos:v3.8.4 Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants