Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for concurrent check for mg5 #3766

Merged
merged 1 commit into from
Sep 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/utils/request_fragment_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ def concurrency_check(fragment,pi,cmssw_version,mg_gp):
error_conc.append("Concurrent parameters used with generateConcurrently=cms.untracked.bool(False) in fragment.")
if "generateConcurrently=cms.untracked.bool(True)" in fragment and mg_gp is True:
error_conc.append("For MG5_aMC requests, currently the concurrent mode for LHE production is not supported due to heavy I/O. So, please set generateConcurrently = cms.untracked.bool(False) in ExternalLHEProducer.")
if "Pythia8ConcurrentHadronizerFilter" not in fragment and mg_gp is False and "RandomizedParameters" not in fragment and "tauola" not in fragment.lower():
error_conc.append("For MG5_aMC requests, the concurrent mode for GEN production should be turned on. Please convert Pythia8HadronizerFilter to Pythia8ConcurrentHadronizerFilter in the fragment")
# if "Pythia8ConcurrentHadronizerFilter" not in fragment and mg_gp is False and "RandomizedParameters" not in fragment and "tauola" not in fragment.lower():
# error_conc.append("For MG5_aMC requests, the concurrent mode for GEN production should be turned on. Please convert Pythia8HadronizerFilter to Pythia8ConcurrentHadronizerFilter in the fragment")
if "ExternalLHEProducer" in fragment and "generateConcurrently=cms.untracked.bool(True)" in fragment:
# first check if the code has correctly implemented concurrent features. Mark conc_check_lhe (LHE step) or conc_check (GEN step) as True if features are found
if "Herwig7GeneratorFilter" not in fragment:
Expand Down