Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Add notebook example #35

Closed
wants to merge 1 commit into from

Conversation

jennyfothergill
Copy link
Member

fixes #27

  • need CI to check that the notebook is working
  • need to add markdown explanations

How should we handle the extra dependencies needed for visualizing/notebooks? I'm hesitant to add them to the container. I guess another container?

What all should the notebook demonstrate? Current ideas:

  • verify that the final density is the density we specify
  • demonstrate what e factor does

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #35 (e9c71a9) into master (9062162) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files           5        5           
  Lines         165      165           
=======================================
  Hits          163      163           
  Misses          2        2           

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chrisjonesBSU
Copy link
Member

Closing since this is outdated with the upcoming change to hoomd3. I'll keep the issue open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notebook tutorial style example and add additional CI job to test it
2 participants