Tom #5
Open
Tom #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables choosing to build - for ARM or x86 - for a particular Android API level - using a particular version of the cross toolchain by setting a few variables at the top of the build script. This also allows specifying where to install the NDK and SDK by setting variables at the top of the build script. The default is to install them in the $HOME directory.
Because libz is in the Android NDK.
ghost
assigned 
| export ANDROID_SDK_DIR="$PWD/android-sdk-linux" | ||
| export ANDROID_NDK_DIR=`find $PWD/* -maxdepth 0 -type d -name 'android-ndk-r*'` | ||
| export ANDROID_SDK_DIR="$HOME/android-sdk-linux" | ||
| export ANDROID_NDK_DIR=`find $HOME -maxdepth 1 -type d -name 'android-ndk-*'` |
There was a problem hiding this comment.
Some people may not want the Android SDK installed in their home directory, so I think this should be configurable if you want to specify a different location for the SDK and NDK.
|
Thanks for the patch. I've taken a look through and made a few suggestions above, but this is certainly a feature worth including. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I made while working on porting GLib for the dLeyna project.
The first commit is so that I can easily build for (1) arm or x86 architecture, (2) a given Android API level, and (3) using a given version of the cross toolchain.
The second commit just removes zlib as a dependency of glib, since it's already supplied in the Android NDK.