fix otel trace handler WithTracing, use another func #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixed OTEL trace interruption when other services requested clusterpedia apiserver. And this is caused by
otelhttp.WithPublicEndpoint()
. As shown here https://github.com/kubernetes/kubernetes/blob/09a5049ca785024edd4955eb82e855d9b5657491/staging/src/k8s.io/apiserver/pkg/endpoints/filters/traces.go#L33C20-L33C20And I think it's a bug of kubernetes, so I replaced it with
WithTracing
in pkg k8s.io/component-base/tracing.Which issue(s) this PR fixes:
Fixes #None
Special notes for your reviewer:
The two
WithTracing
is almost same and we can customize the span name by the new one. So it's more flexible.Does this PR introduce a user-facing change?: