Add typecheck to CI

cloudydeno · Aug 14, 2023 · c09d0b5 · c09d0b5
1 parent 68c849a
commit c09d0b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/deno-ci.yaml b/.github/workflows/deno-ci.yaml
@@ -35,8 +35,8 @@ jobs:
         key: deno-https/v1-${{ github.sha }}
         restore-keys: deno-https/v1-
 
-    # - name: Check mod.ts
-    #   run: time deno check --unstable lib/spdy-transport.ts
+    - name: Check mod.ts
+      run: time deno check lib/mod.ts
 
     - name: Run tests
       run: time deno test test/spdy/v3-parser-test.ts

diff --git a/lib/spdy-transport/stream.ts b/lib/spdy-transport/stream.ts
@@ -104,7 +104,9 @@ export class Stream extends EventEmitter {
       isServer: this.connection.isServer(),
       // state.debug = state.isServer ? debug.server : debug.client
 
+      //@ts-expect-error should be a common interface instead of a concrete union
       framer: connectionState.framer,
+      //@ts-expect-error should be a common interface instead of a concrete union
       parser: connectionState.parser,
 
       request: options.request,
@@ -175,9 +177,11 @@ export class Stream extends EventEmitter {
       }
       break;
     case 'HEADERS':
+      //@ts-expect-error optionalness mismatch
       this._handleHeaders(frame);
       break;
     case 'RST':
+      //@ts-expect-error optionalness mismatch
       this._handleRST(frame);
       break;
     case 'WINDOW_UPDATE':
@@ -187,6 +191,7 @@ export class Stream extends EventEmitter {
       this._handlePriority(frame);
       break;
     case 'PUSH_PROMISE':
+      //@ts-expect-error optionalness mismatch
       this._handlePushPromise(frame);
       break;
     }