Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CloudWatch event rules and add missed CloudWatch log outputs #29

Closed
wants to merge 1 commit into from

Conversation

SweetOps
Copy link

what

  • add CloudWatch event rules
  • add missed CloudWatch log outputs
  • remove variable sns_subscriptions

why

  • CloudWatch event rules are useful for invoking lambda by cron expressions
  • CloudWatch log outputs are useful for external usage
  • sns_subscriptions is unused variable

references

@SweetOps SweetOps requested review from a team as code owners August 30, 2022 13:48
@SweetOps
Copy link
Author

/test all

@SweetOps SweetOps closed this Oct 6, 2022
@arichtman
Copy link

I would like to progress this change as we require the ability to add event rules for the Lambda and current version (v0.4.1) doesn't seem to actually do anything with the input var cloudwatch_event_rules

Is there something I can help with?

@sodre
Copy link

sodre commented Oct 17, 2022

@SweetOps, same issue here. Did we close the issue by mistake before merging or is the approach to use a separate module to invoke the lambda function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example about cloudwatch_event_rules
3 participants