Support atmos terraform apply --from-plan with additional flags
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when atmos generates the plan-file arg for `terraform apply`, it puts it first, and then appends any additional args or flags that may be specified by the user. Terraform is very particular about the order of args and flags, and crashes with an error if flags follow the plan-file args. Instead, put the plan-file arg at the end of the command, after any additional flags or args. For example, with this change `atmos terraform apply -s $STACK $COMPONENT planfile -- -parallelism=1` will call `terraform apply -parallelism=1 planfile` instead of `terraform apply planfile -parallelism=1`.
aknysh
approved these changes
Sep 1, 2024
|
These changes were released in v1.87.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
atmos terraform applyto make sure the plan-file arg is placed after any flags specified by the userwhy
--parallelism=1), or it crashes.atmos terraform applyaccepts aplan-filearg, or generates one when--from-planis used. When this happens, it currently puts the plan-file arg first, before any additional flags specified by the user.atmos terraform apply --from-plan -- -parallelism=1. In this example, atmos tries to callterraform apply <planfile> --paralellism=1and terraform immediately crashes withError: Too many command line argumentsreferences