Skip to content

Commit

Permalink
Change the test to polling instead of just a single sleep
Browse files Browse the repository at this point in the history
- Avoid flakyness due to time it takes to bind a service

Signed-off-by: João Pereira <[email protected]>
  • Loading branch information
joaopapereira committed Aug 16, 2024
1 parent 835b2ca commit 69acaba
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions integration/v7/isolated/service_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,16 @@ var _ = Describe("service command", func() {
})

It("displays the bound apps", func() {
//Delay to reduce flakiness
time.Sleep(10 * time.Second)
session := helpers.CF(serviceCommand, serviceInstanceName, "-v")
Eventually(session).Should(Exit(0))

Expect(session).To(SatisfyAll(
Say(`Showing bound apps:\n`),
Say(`name\s+binding name\s+status\s+message\n`),
Say(`%s\s+%s\s+create succeeded\s*\n`, appName1, bindingName1),
Say(`%s\s+%s\s+create succeeded\s*\n`, appName2, bindingName2),
))
Eventually(func(g Gomega) {
session := helpers.CF(serviceCommand, serviceInstanceName, "-v").Wait()
g.Expect(session).Should(Exit(0))
g.Expect(session).Should(SatisfyAll(
Say(`Showing bound apps:\n`),
Say(`name\s+binding name\s+status\s+message\n`),
ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName1, bindingName1),
ContainSubstring(`%s\s+%s\s+create succeeded\s*\n`, appName2, bindingName2),
))
}).Should(Succeed())
})
})

Expand Down

0 comments on commit 69acaba

Please sign in to comment.