-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local terraform binary #603
Use local terraform binary #603
Conversation
the whole idea that we packed a specific terraform binary with bbl. |
Hi @ramonskie! Having a "one functional binary without caring about dependencies", like BBL, is indeed great. But we have different use-cases where we would like to be able to select the terraform version without changing the whole bbl binary; to name a few:
This is an opt-in feature which does not change the normal bbl behaviour (and, hopefully, does not increase its size). Would it be preferable to explicitly set the custom terraform binary location instead of a boolean flag? |
we are always happy to review prs if you have found any bugs. so we could upgrade terraform if you found that solved something. and maby we should even keep up with the latest terraform versions in our ci and yes it would be preferable if you set he terraform location instead of boolean flag. |
@romain-dartigues have you already had time to fix the adjustments? |
Converting to draft, feel free to mark ready for review once the above points have been addressed. |
0945f05
to
f0efeb5
Compare
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Today it is not possible to choose which version of terraform to use with bbl.
This change adds a global flag to use the local terraform binary if it exists.