Adding support for EFI based stemcells. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the root disks. It doesn't take in account if a system has more then 1 partition
beyhan
reviewed
Apr 25, 2024
jpalermo
requested review from
a team,
aramprice and
nouseforaname
and removed request for
a team
|
@lnguyen already tested it by using it in stemcells, any reviewer willing to take a look at just the code and make sure it looks sane? |
aramprice
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP repartition the root disks. It doesn't take in account if a system has more then 1 partition.
This has been tested with EFI stemcell and non EFI stemcell