misc: Apply suggestions from code review

Co-authored-by: Bruno Dias <[email protected]>

src/clib-install.c

@@ -281,7 +281,7 @@ static int install_package(const char *slug) {
   char* author = clib_package_parse_author(slug);
   char* name = clib_package_parse_name(slug);
   char* package_id = clib_package_get_id(author, name);
-  registry_package_ptr_t package_info = registry_manger_find_package(registries, package_id);
+  registry_package_ptr_t package_info = registry_manager_find_package(registries, package_id);
   if (!package_info) {
     debug(&debugger, "Package %s not found in any registry.", slug);
     return -1;

src/common/clib-package-installer.c

@@ -88,7 +88,7 @@ static inline int install_packages(list_t *list, const char *dir, int verbose) {
     if (NULL == slug)
       goto loop_cleanup;
 
-    registry_package_ptr_t package_info = registry_manger_find_package(registries, package_id);
+    registry_package_ptr_t package_info = registry_manager_find_package(registries, package_id);
     if (!package_info) {
       debug(&_debugger, "Package %s not found in any registry.", slug);
       return -1;

src/registry/github-registry.c

@@ -18,14 +18,16 @@
 #include <curl/curl.h>
 #include <string.h>
 
+#define GITHUB_BASE_URL "https://github.com/"
+
 /**
  * Add `href` to the given `package`.
  */
 static void add_package_href(registry_package_ptr_t self) {
     size_t len = strlen(self->id) + 20; // https://github.com/ \0
     self->href = malloc(len);
     if (self->href)
-        sprintf(self->href, "https://github.com/%s", self->id);
+        sprintf(self->href, GITHUB_BASE_URL "%s", self->id);
 }
 
 /**
@@ -129,4 +131,3 @@ list_t *github_registry_fetch(const char *url) {
     http_get_free(res);
     return list;
 }
-

src/registry/registry-manager.c

@@ -48,7 +48,7 @@ void registry_manager_fetch_registries(registries_t registries) {
   registry_iterator_destroy(it);
 }
 
-registry_package_ptr_t registry_manger_find_package(registries_t registries, const char* package_id) {
+registry_package_ptr_t registry_manager_find_package(registries_t registries, const char* package_id) {
   registry_iterator_t it = registry_iterator_new(registries);
   registry_ptr_t reg;
   while ((reg = registry_iterator_next(it))) {

src/registry/registry-manager.h

@@ -39,6 +39,6 @@ void registry_iterator_destroy(registry_iterator_t iterator);
  * @param package_id the identifier of the package "<namespace>/<package_name>"
  * @return a pointer to the package if it could be found or NULL
  */
-registry_package_ptr_t registry_manger_find_package(registries_t registries, const char* package_id);
+registry_package_ptr_t registry_manager_find_package(registries_t registries, const char* package_id);
 
 #endif//CLIB_SRC_REGISTRY_REGISTRY_MANAGER_H

src/repository/gitlab-repository.c

@@ -10,14 +10,16 @@
 #include <string.h>
 #include <url/url.h>
 
+#define GITLAB_API_V4_URL "https://%s/api/v4%s/repository/files/%s/raw?ref=master"
+
 // GET :hostname/api/v4/projects/:id/repository/files/:file_path/raw
 char* gitlab_repository_get_url_for_file(const char*package_url, const char* slug, const char* version, const char *file, const char* secret) {
   url_data_t *parsed = url_parse(package_url);
 
   int size = strlen(parsed->hostname) + strlen(parsed->pathname) + strlen(file) + 64;
   char *url = malloc(size);
   if (url) {
-    snprintf(url, size, "https://%s/api/v4%s/repository/files/%s/raw?ref=master", parsed->hostname, parsed->pathname, file);
+    snprintf(url, size, GITLAB_API_V4_URL, parsed->hostname, parsed->pathname, file);
   }
 
   url_free(parsed);