Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new filters and operations #343

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add new filters and operations #343

wants to merge 13 commits into from

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Sep 18, 2024

Functions added:

  • pixel_count_map
  • extension_ratio_map
  • sub_stack
  • reduce_stack
  • reduce_label_to_centroids
  • exclude_label_with_values_out_of_range
  • exclude_label_with_values_within_range

The following function has equivalent renaming for future:

  • exclude_label_with_values_out_of_range --> remove_label_out_of_range

  • exclude_label_with_values_within_range --> remove_label_within_range

  • reduce_label_to_centroids reuse the statistics function (see multiple way of computing some label measurement pyclesperanto_prototype#340 )

  • exclude_label_with_values_out_of_range is reused for exclude_label_by_size which change some functions tiers.

This PR aim to answer this request: clEsperanto/napari_pyclesperanto_assistant#73

@StRigaud
Copy link
Member Author

@haesleinhuepf can you tell me if this enough for continuing the shift of the napari-assistant toward using pyclesperanto ?
Would you need more function?

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 24.13793% with 88 lines in your changes missing coverage. Please review.

Project coverage is 49.12%. Comparing base (115caa8) to head (cbb0f79).

Files with missing lines Patch % Lines
clic/src/tier4/filter_label_by_values.cpp 10.00% 13 Missing and 5 partials ⚠️
clic/src/tier2/stack_operations.cpp 0.00% 16 Missing ⚠️
clic/src/tier4/parametrics_map.cpp 17.64% 9 Missing and 5 partials ⚠️
clic/src/tier4/centroids_of_labels.cpp 37.50% 1 Missing and 9 partials ⚠️
clic/src/tier1/replace_values.cpp 35.71% 6 Missing and 3 partials ⚠️
clic/src/tier5/reduce_labels_to_centroids.cpp 40.00% 0 Missing and 6 partials ⚠️
clic/src/tier3/statistics_of_labelled_pixels.cpp 44.44% 0 Missing and 5 partials ⚠️
clic/src/tier5/filter_label_by_size.cpp 37.50% 0 Missing and 5 partials ⚠️
clic/src/tier6/remove_objects.cpp 0.00% 4 Missing ⚠️
clic/src/tier7/fill_holes.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   49.76%   49.12%   -0.64%     
==========================================
  Files         240      244       +4     
  Lines        3864     3953      +89     
  Branches     1749     1797      +48     
==========================================
+ Hits         1923     1942      +19     
- Misses        558      603      +45     
- Partials     1383     1408      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants