RQ Job Timeout Handling #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always close the temp file on exception handling. - Added handling for the rq job timeout.
ThrawnCA
reviewed
Aug 2, 2024
ckanext/xloader/jobs.py
Outdated
| @@ -222,6 +222,11 @@ def tabulator_load(): | |||
| resource_id=resource['id'], | |||
| mimetype=resource.get('format'), | |||
| logger=logger) | |||
| except rq_timeouts.JobTimeoutException as e: | |||
There was a problem hiding this comment.
Wouldn't it be better to put this further out, eg line 256?
There was a problem hiding this comment.
@ThrawnCA moved out to wrap the tabulator_load method call with the try/catch. Lemme know if that is actually the right place. Thanks!
There was a problem hiding this comment.
It's a start, but I think line 267 would be a better place.
- Moved try/catch for `tabulator_load` rq timeout up.
ThrawnCA
reviewed
Aug 16, 2024
| tabulator_load() | ||
| try: | ||
| tabulator_load() | ||
| except rq_timeouts.JobTimeoutException as e: |
There was a problem hiding this comment.
This isn't catching timeouts from the tabulator_load on line 266. Perhaps move this block to the outer catch, line 267?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(logic): close temp file on rq timeout;