Event Settings: rename labels for public listing, calendar links

[mlutfy]

Overview

Renames some settings on Manage Event.

This are perhaps obvious to many experienced CiviCRM users, but I find that they systematically cause discomfort to admins during training.

Before

After

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[guyiac]

I also think the order is still wonky. Should be:
Active or not
Public or not
Display the Calendar links
Display the social media

You could even argue that where this is on the page is wonky. Really, Active and Public options should be at the top of the page. But that gets deeper.

[mlutfy]

Good catch, thanks @guyiac !

Here is an updated version:

[mlutfy]

jenkins, test this please

[petednz]

TBH I stumble over the wording

Display so that people can easily add the event to their calendar (..)

wondering if something like below is more in keeping with the language style

Provide links/icons for adding the event to calendars (.....)

[mlutfy]

Definitely a typo, thanks @petednz !

How's this?

On another note, I would have liked to remove the ? from the social media setting, but I don't want to break the translation strings just because of that.

[wmortada]

@bgm Thanks for working on this. I think that's much better.

My suggestion to improve it further is to shorten the text and make them all statements rather than questions so they are consistent.

• Event is active
• Display the event in public listings
• Include a map to the event location
• Provide calendar links (iCalendar, Google Calendar)
• Include social media sharing links

[wmortada]

Or you could even separate the last three as follows:

• Event is active
• Display the event in public listings

Include with event information:

• Map to event location
• Calendar links (iCalendar, Google Calendar)
• Social media sharing links