Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChartKit - add new chart type: Series Chart #31133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Sep 19, 2024

Overview

Adds additional chart kit chart type Series Chart.

This allows plotting multi-line data according to the value of a given column - e.g. "Activity Type" or "Contact Type". (Previously multi-line/bar charts require having separate columns - e.g. Total Amount, Tax Amount)

image

Technical Details

We have to create a 2-part dimension when we build the chart. This PR splits out the buildCrossfilter step from the render pipeline of the main chart component to allow more fine-grained overriding in the chart type (ie we can build a custom dimension, but use the standard grouping function).

Comments

I've updated all the chart type icons to use Font Awesome 6 icons. There aren't really enough chart icons in the Free iconset for our different types, but I've tried to make the best of what we have:

image

Copy link

civibot bot commented Sep 19, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 19, 2024
@ufundo ufundo changed the title ChartKit - add series chart type ChartKit - add new chart type: Series Chart Sep 19, 2024
@ufundo ufundo marked this pull request as ready for review September 19, 2024 01:03
@ufundo ufundo force-pushed the chart-kit-series branch 3 times, most recently from 6812669 to 8906a8a Compare September 19, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants