ChartKit - add new chart type: Series Chart #31133
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds additional chart kit chart type Series Chart.
This allows plotting multi-line data according to the value of a given column - e.g. "Activity Type" or "Contact Type". (Previously multi-line/bar charts require having separate columns - e.g. Total Amount, Tax Amount)
Technical Details
We have to create a 2-part dimension when we build the chart. This PR splits out the
buildCrossfilter
step from the render pipeline of the main chart component to allow more fine-grained overriding in the chart type (ie we can build a custom dimension, but use the standard grouping function).Comments
I've updated all the chart type icons to use Font Awesome 6 icons. There aren't really enough chart icons in the Free iconset for our different types, but I've tried to make the best of what we have: