Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an Action to install Packer in our GitHub Actions workflows #187

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request removes our manual shell code to download and install Packer and replaces it with the hashicorp/setup-packer Action.

💭 Motivation and context

We (@jsf9k) discovered an issue in the ubuntu-24.04 GitHub Actions runner image (that will soon be what the ubuntu-latest tag references) due to the images no longer coming with Packer or Terraform preinstalled. While discussing backporting the change he was going to make in cisagov/skeleton-packer I discovered that this Action exists and has been a thing. Since we already use the hashicorp/setup-terraform Action to install Terraform, it makes sense to use their hook to install Packer as well.

🧪 Testing

Automated tests pass. I also verified functionality in cisagov/skeleton-packer in this workflow run.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Instead of manually installing Packer we can instead leverage the
hashicorp/setup-packer Action just as we do for Terraform.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels Aug 13, 2024
@mcdonnnj mcdonnnj self-assigned this Aug 13, 2024
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! 👍

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants