Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #185

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update pre-commit hooks #185

wants to merge 2 commits into from

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull requests updates the pre-commit hooks in our configuration.

Note

The prettier hook has a manual configuration because I had errors with the alpha releases of v4 and wanted to make sure we were using the latest available release of v3. This is working around a limitation of how the pre-commit auto-generated mirrors-<tool> hooks are updated.

💭 Motivation and context

Regular updates are important!

🧪 Testing

Automated tests pass. I tested these updated hooks in a number of repositories and saw no issues.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Update pre-commit hook versions
170624f 
This is done automatically with the `pre-commit autoupdate` command.
The pre-commit/mirrors-prettier hook was manually held back because the
latest tags are for alpha releases of the next major version.
@mcdonnnj
Manually update the prettier hook
a881e6a 
Use the latest v3 release available from NPM.
@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label Aug 13, 2024
@mcdonnnj mcdonnnj self-assigned this Aug 13, 2024
jsf9k
jsf9k approved these changes Aug 13, 2024
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r