Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OPA version from v0.67.1 to v0.68.0 #1318

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2024

🗣 Description

  • This pull request was created by a GitHub Action to bump ScubaGear's Open Policy Agent (OPA) executable version dependency.
  • Please fill out the rest of the template that the Action did not cover.

💭 Motivation and context

  • Bump to the latest OPA version v0.68.0

🧪 Testing

  • Currently a human should still check if bumping the OPA version affects ScubaGear.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@github-actions github-actions bot added the version bump This issue or pull request increments the version number label Sep 17, 2024
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tests pass other than known issue with y2zj1 tenant: https://github.com/cisagov/ScubaGear/actions/runs/10907592818

Ran OPA/PowerShell unit tests and linter workflows successfully.

@schrolla schrolla added this to the Jellyfish milestone Sep 18, 2024
@schrolla schrolla self-requested a review September 19, 2024 14:12
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code changes which look good. Ran all rego unit tests successfully. Ran Invoke-SCuBA on all products in test tenant which worked as expected. Reviewed OPA security advisories, no new advisories found.
Reviewed OPA related documentation and found no old version strings in text.

One item of note... the documentation does include a picture showing a screenshot of the left-hand menu displaying version 0.64. I'd recommend either removing the screenshot to ease maintenance for version bumps. Either way, it isn't a big enough deal to not approve the version bump here.

@mitchelbaker-cisa
Copy link
Collaborator

Reviewed the code changes which look good. Ran all rego unit tests successfully. Ran Invoke-SCuBA on all products in test tenant which worked as expected. Reviewed OPA security advisories, no new advisories found. Reviewed OPA related documentation and found no old version strings in text.

One item of note... the documentation does include a picture showing a screenshot of the left-hand menu displaying version 0.64. I'd recommend either removing the screenshot to ease maintenance for version bumps. Either way, it isn't a big enough deal to not approve the version bump here.

Thanks for reviewing, created a new issue for the OPA documentation you brought up. #1321

@mitchelbaker-cisa
Copy link
Collaborator

mitchelbaker-cisa commented Sep 19, 2024

@nanda-katikaneni this is ready to merge.

@nanda-katikaneni nanda-katikaneni merged commit 4d9c7a4 into main Sep 20, 2024
24 checks passed
@nanda-katikaneni nanda-katikaneni deleted the opa-version-bump-0.68.0 branch September 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants