-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OPA version from v0.67.1 to v0.68.0 #1318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests pass other than known issue with y2zj1 tenant: https://github.com/cisagov/ScubaGear/actions/runs/10907592818
Ran OPA/PowerShell unit tests and linter workflows successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code changes which look good. Ran all rego unit tests successfully. Ran Invoke-SCuBA on all products in test tenant which worked as expected. Reviewed OPA security advisories, no new advisories found.
Reviewed OPA related documentation and found no old version strings in text.
One item of note... the documentation does include a picture showing a screenshot of the left-hand menu displaying version 0.64. I'd recommend either removing the screenshot to ease maintenance for version bumps. Either way, it isn't a big enough deal to not approve the version bump here.
Thanks for reviewing, created a new issue for the OPA documentation you brought up. #1321 |
@nanda-katikaneni this is ready to merge. |
073cde8
to
1a8383a
Compare
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist