Make ScubaResults.json the default JSON output

[buidav]

🗣 Description

• Makes ScubaResults.json the default output for ScubaGear
• Inverts the -MergeJSON switch to -KeepIndividualJSON parameter.
• Make ScubaCached backwards compatible with ScubaResults.json
• Update any tests that need it to match the new ScubaGear output behavior.

TODO:

• Update the functional and smoke tests to work with the ScubaResults.json in Update the Functional and Smoke Tests to use the ScubaResults.json rather than the ProviderSettingsExport.json #1317

💭 Motivation and context

Closes #1205
Closes #1023

🧪 Testing

• Run Invoke-SCuBA. Observe ScubaResults.json is the default output.

• Run Invoke-SCuBA -KeepIndividualJSON. Observe ProviderSettingsExport.json is output instead of ScubaResutls.

• Run Invoke-SCuBACached. Observe ScubaResults.json is the default output.

• Run Invoke-SCuBACached -ExportProvider $false. Observe ScubaCached still performs as expected.

• Run Invoke-SCuBACached with the -KeepIndividualJSON flag. Observe performance benefit with this flag. Along with no change in behavior.

• Run functional tests for a product as see no breaking changes.

• For reviewers and merge coordinator Check smoke tests or other workflows to see if there are errors from the new output behavior.

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• PR targets the correct parent branch (e.g., main or release-name) for merge.
• Changes are limited to a single goal - eschew scope creep!
• Changes are sized such that they do not touch excessive number of files.
• All future TODOs are captured in issues, which are referenced in code comments.
• These code changes follow the ScubaGear content style guide.
• Related issues these changes resolve are linked preferably via closing keywords.
• All relevant type-of-change labels added.
• All relevant project fields are set.
• All relevant repo and/or project documentation updated to reflect these changes.
• Unit tests added/updated to cover PowerShell and Rego changes.
• Functional tests added/updated to cover PowerShell and Rego changes.
• All relevant functional tests passed.
• All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

• PR passed smoke test check.

• Feature branch has been rebased against changes from parent branch, as needed

  Use Rebase branch button below or use this reference to rebase from the command line.

• Resolved all merge conflicts on branch

• Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

• Feature branch deleted after merge to clean up repository.
• Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

[adhilto]

Some minor things:

[mitchelbaker-cisa]

Ran all of these successfully with no issue. A few small comments to add is all.

• Run Invoke-SCuBA. Observe ScubaResults.json is the default output.
• Run Invoke-SCuBA -KeepIndividualJSON. Observe ProviderSettingsExport.json is output instead of ScubaResutls.
• Run Invoke-SCuBACached. Observe ScubaResults.json is the default output.
• Run Invoke-SCuBACached -ExportProvider $false. Observe ScubaCached still performs as expected.
• Run Invoke-SCuBACached with the -KeepIndividualJSON flag. Observe performance benefit with this flag. Along with no change in behavior.
• Run functional tests for a product as see no breaking changes (ran aad functional tests successfully)

[adhilto]

Looks great. A few final notes:

• I manually ran the nightly functional tests, they are all passing on this branch.
• The one failure from the smoke test is related to the encoding issue, fixed in Fix encoding issue by removing BOM from provider output files #1302, so not applicable here.

[buidav]

@nanda-katikaneni this is ready to merge.

Not sure why the checks are saying unsuccessful when looking at them individually they're all passing.
Fixed it.