Support async routes #602
Closed
Support async routes #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI, I'm running into some timing issues now using this, so definitely not ready for merge. |
|
This branch has started to feel a bit too hacky and unstable to me, so unless anyone has some good counterarguments, I think I favour the approach in this new PR. Gonna close this one for now, if people think this one's better after all we can always reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably shouldn't be merged yet, just opening this PR for feedback/discussion.
In this PR I've implemented (part of) the API I proposed here. After playing around with it a bit I initially got stuck when trying to make my changes work with the synchronous
toStringAPI. But then I realized we could just decide not to supporttoStringon async routes and throw an AssertionError when anyone tries it. Thoughts?