Update choo #527
Update choo #527
Conversation
|
@tornqvist What's going with the tests? I forked bankai recently from master and just wanted to update the README with some details on documentify, but the tests are not passing. How can a readme update fail tests?? |
|
@shotlom the failure on your PR is because of a test bug on windows, don't worry about it |
|
Ok - but does that mean the pull request dies? |
|
@shotlom Our PRs are failing for different reasons, and it doesn't means that your PR is dead. |
|
Thanks @tornqvist - I don't understand how I can fork the master prod release branch and then have if fail when merging with no conflicts unless prod release is failing. What have I done wrong here? |
|
This should be ready to merge now that |
There was a problem hiding this comment.
I don't know if anybody actually does it, but technically bankai can be used with non-choo apps as well. I think we shouldn't introduce a peerDependency on choo. we might be able to support both choo 6 and 7 after this PR too, then we don't need to warn people about older choo versions anyway.
This is a preemptive PR in anticipation of choojs/choo#700.